fix visibility of exceptions within Boost.Graph#118
Merged
pdimov merged 1 commit intoboostorg:developfrom Sep 29, 2018
apolukhin:antoshkka/visibility-issues
Merged
fix visibility of exceptions within Boost.Graph#118pdimov merged 1 commit intoboostorg:developfrom apolukhin:antoshkka/visibility-issues
pdimov merged 1 commit intoboostorg:developfrom
apolukhin:antoshkka/visibility-issues
Conversation
Contributor
Contributor
|
It looks like this kind of change doesn't change code functionality, only linking. It also appears that this kind of change could be applied more broadly. Are there other things which should be guarded with |
Member
Author
No. Only new exception types. Other things should be OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to avoid issues with
-fvisibility=hiddenbuilds (those are now default in Boost develop branch).More info on the macro available here
Related issue: boostorg/graph_parallel#16